Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(fix) add quotes to ts store regex #403

Merged
merged 1 commit into from
Sep 8, 2021
Merged

(fix) add quotes to ts store regex #403

merged 1 commit into from
Sep 8, 2021

Conversation

dummdidumm
Copy link
Member

Fixes #402

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR relates to an outstanding issue, so please reference it in your PR, or create an explanatory one for discussion. In many cases features are absent for a reason.
  • This message body should clearly illustrate what problems it solves. If there are related issues, remember to reference them.
  • Ideally, include a test that fails without this PR but passes with it. PRs will only be merged once they pass CI. (Remember to npm run lint!)

Tests

  • Run the tests with npm test or yarn test

kaisermann
kaisermann approved these changes Sep 8, 2021
View reviewed changes
Copy link
Member

@kaisermann kaisermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

neat 🙏

@kaisermann kaisermann merged commit 9f2d7a0 into sveltejs:main Sep 8, 2021
@dummdidumm dummdidumm deleted the fix-ts-regex branch September 9, 2021 10:00
@kaisermann kaisermann added the bug Something isn't working label Sep 9, 2021
@kaisermann
Copy link
Member

Released in v4.9.4 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaisermann kaisermann kaisermann approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade from 4.8.0 - 4.9.0: unterminated string literal error during svelte-check, build fails
2 participants
@dummdidumm @kaisermann